From 0e3481b593e97bbd2297c89fd4373c895a0a16c7 Mon Sep 17 00:00:00 2001 From: Steven Date: Wed, 20 Mar 2024 00:07:23 +0800 Subject: [PATCH] chore: handle unspecified visibility --- server/route/api/v1/shortcut_service.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/server/route/api/v1/shortcut_service.go b/server/route/api/v1/shortcut_service.go index b67a4a1..b35eabc 100644 --- a/server/route/api/v1/shortcut_service.go +++ b/server/route/api/v1/shortcut_service.go @@ -145,6 +145,18 @@ func (s *APIV2Service) CreateShortcut(ctx context.Context, request *apiv1pb.Crea Visibility: storepb.Visibility(request.Shortcut.Visibility), OgMetadata: &storepb.OpenGraphMetadata{}, } + if shortcutCreate.Visibility == storepb.Visibility_VISIBILITY_UNSPECIFIED { + getWorkspaceSettingResponse, err := s.GetWorkspaceSetting(ctx, nil) + if err != nil { + return nil, status.Errorf(codes.Internal, "failed to get workspace setting, err: %v", err) + } + workspaceSetting := getWorkspaceSettingResponse.Setting + visibility := apiv1pb.Visibility_PRIVATE + if workspaceSetting.DefaultVisibility != apiv1pb.Visibility_VISIBILITY_UNSPECIFIED { + visibility = workspaceSetting.DefaultVisibility + } + shortcutCreate.Visibility = storepb.Visibility(visibility) + } if request.Shortcut.OgMetadata != nil { shortcutCreate.OgMetadata = &storepb.OpenGraphMetadata{ Title: request.Shortcut.OgMetadata.Title,